Add Arch-backed UK target provider#1
Draft
MaxGhenis wants to merge 22 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nan_to_nanlabel while retaining a truthful lower-bound filtervoa/council_tax/{LA}/{band}target names andlocal_authorityfilters without changing production mapping codeVerification
uv run --extra dev ruff check src/microplex_uk/targets/arch.py tests/targets/test_arch.pyuv run --extra dev pytest tests/targets/test_arch.py -q-> 24 passeduv run --extra dev --with tables pytest -q-> 49 passedhousing/rent_socialfor 2025 name, source, unit, variable, and value (£30.68bn)housing/rent_privatefor 2025 name, source, unit, variable, and value (£89.0352bn)ons/household_land_value,ons/corporate_land_value, andons/land_valuefor 2024, 2025, and 2026voa/council_taxtarget names covered with 0 missing names and 0 value mismatches, including 2,563 local-authority band targetsuv run --extra dev ruff check src/microplex_uk/targets/arch.py tests/targets/test_arch.pyuv run --extra dev pytest tests/targets/test_arch.py -q-> 24 passeduv run --extra dev --with tables pytest -q-> 49 passedSource smoke checks
housing/rent_socialwith source-to-target adjustment metadatahousing/rent_privatewith source-to-target adjustment metadatavoa/council_taxtarget names matched exactly, including the 2,563 source-numeric local-authority band facts from VOACTSOP1.0