Allow nonnumeric regime-aware donor targets#245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the next Stage 05 chained MicroImpute failure in the large PUF block. After #243 cleared duplicate DataFrame labels, the adapter crashed when it called
get_regime()for every target. MicroImpute only exposes regimes for numeric targets; boolean/categorical targets likebusiness_is_sstbare handled through its non-numeric bundle and should not require a numeric regime.Changes:
_regimesmap instead of forcingget_regime()on every target_fitted_columnsso generation can still emit non-numeric targets from the fitted resultself_employment_incomeplus booleanbusiness_is_sstbVerification
uv run ruff format src/microplex_us/pipelines/donor_imputers.py tests/pipelines/test_regime_aware_donor_imputer.pyuv run ruff check src/microplex_us/pipelines/donor_imputers.py tests/pipelines/test_regime_aware_donor_imputer.pyuv run --extra dev --extra policyengine python -m pytest -q tests/pipelines/test_regime_aware_donor_imputer.py-> 12 passeduv run --extra dev --extra policyengine python -m pytest -q tests/pipelines/test_regime_aware_donor_imputer.py tests/test_variables.py tests/test_pe_source_impute_specs.py tests/test_pe_source_impute_engine.py tests/pipelines/test_zi_qrf_backend.py tests/pipelines/test_donor_imputer_negative_preservation.py tests/data_sources/test_scf_net_worth_components.py -k "imputer or regime_aware or columnwise or donor_imputation_block_specs or pe_source"-> 33 passed, 38 deselected