Add ?country= deep link to select the benchmark view#57
Merged
Conversation
Reads ?country=uk (or ?view=us) on load and locks the selected view, so the UK benchmark can be linked to and embedded directly (e.g. in slides) rather than relying on timezone/language auto-detection. Toggling the country selector now also syncs the URL so the current view is shareable. SSR-safe (window-guarded).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
?country=URL override to the PolicyBench dashboard:?country=uk(or?view=uk) opens directly on the UK benchmark;?country=uson the US one.replaceState), so the current view is shareable/embeddable.window-guarded.Why
So the UK benchmark can be linked to and embedded directly (e.g. in a slide deck for a UK audience) instead of relying on the visitor's timezone/language. Today the embed always opens on US unless the viewer happens to be detected as UK.
Test plan
bun run lint(max-warnings=0) — cleanbun run test— 7/7 passbun run build— succeeds/?country=uk→ UK view;/?country=us→ US view; no param → existing auto-detect; toggling updates the URL.