fix: query TaxBenefitModel by name before getting version#69
Merged
Conversation
…tions Adds run_structural_reform tool for the agent to run economy-wide structural reforms: - Agent calls POST /agent/run-structural-reform to trigger Modal - Modal applies simulation_modifier to reform simulation - Decile impacts calculated and stored - Agent polls until completion Also adds simulation_modifier support to household calculations: - Updated Modal household functions to use low-level Simulation API when modifier present - Added helper functions _calculate_uk/us_household_with_modifier - Updated _get_policy_data to include simulation_modifier - Agent can use policy_id with modifier in /household/calculate Fixes broken policyengine.outputs.inequality/poverty imports (module doesn't exist yet). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
TaxBenefitModelVersion doesn't have a name field - need to query TaxBenefitModel first, then get the version by model_id. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/agent/run-structural-reformendpoint was failing withAttributeError: namebecause it queriedTaxBenefitModelVersion.namewhich doesn't exist - thenamefield is onTaxBenefitModel.Fixed by querying
TaxBenefitModelfirst by name, then getting the version bymodel_id.