Make Modal gateway auth optional until configured#467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GATEWAY_AUTH_REQUIRED=1.policyengine-gateway-authModal secret during deploy and attach it to the gateway app, so auth can be enabled by settingGATEWAY_AUTH_ISSUER,GATEWAY_AUTH_AUDIENCE, andGATEWAY_AUTH_REQUIRED.Why
#466 deployed to beta, but beta integration failed because the gateway started enforcing auth without any
GATEWAY_AUTH_*config in this repo. Production deploy was skipped, so production is still on the older unauthenticated gateway. This keeps the deployment unblocked while leaving a clean switch for real auth enforcement once credentials are configured.Testing
env -u UV_FROZEN uv run pytest tests/gateway/test_auth.py tests/gateway/test_endpoints.py tests/test_modal_scripts.py -qenv -u UV_FROZEN uv run pytest -qenv -u UV_FROZEN uv run --with ruff ruff format --check src