Ignore deprecated medical expense input#3574
Closed
MaxGhenis wants to merge 2 commits into
Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3574 +/- ##
==========================================
- Coverage 77.81% 76.58% -1.24%
==========================================
Files 65 66 +1
Lines 3877 3968 +91
Branches 697 724 +27
==========================================
+ Hits 3017 3039 +22
- Misses 683 752 +69
Partials 177 177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Closing in favor of #3576, which now includes the deprecated medical expense input fallback plus structured 400 responses for unrecognized calculate inputs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
medical_out_of_pocket_expenses.Context
MFB falls back from
household.api.policyengine.org/us/calculatetoapi.policyengine.org/us/calculatewhen household API requests time out. Household API already ignoresmedical_out_of_pocket_expensesand returns a warning, but the standard API fallback still returns a fast HTTP 500 for payloads containing the removed field.This applies the same graceful behavior to standard API household calculations so MFB fallback requests can keep computing while they migrate to
other_medical_expensesandhealth_insurance_premiums.Testing
uv run pytest tests/test_deprecated_inputs.py -quv run ruff check policyengine_api/endpoints/household.py policyengine_api/utils/deprecated_inputs.py tests/test_deprecated_inputs.py