Route API v1 simulations through the Stage 5 entrypoint#3776
Draft
anth-volk wants to merge 4 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3776 +/- ##
==========================================
+ Coverage 80.03% 80.71% +0.67%
==========================================
Files 70 74 +4
Lines 4342 4422 +80
Branches 809 822 +13
==========================================
+ Hits 3475 3569 +94
+ Misses 648 623 -25
- Partials 219 230 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SimulationAPIClientand retain compatibility aliases for the former Modal-specific client;Why
API v1 needs to adopt the separate Stage 5 simulation service boundary without coupling the migration to a one-way cutover. Keeping both targets selectable allows controlled qualification, cross-polling, and immediate rollback while the new Cloud Run entrypoint continues to use the existing Modal gateway underneath.
Impact
The default remains the direct old-gateway path until an operator deliberately deploys and promotes a revision configured for the Cloud Run entrypoint. Existing imports remain available through explicit compatibility aliases.
Root cause
The previous client and deployment configuration assumed that API v1 called the Modal-hosted gateway directly. That made the simulation service boundary inseparable from the Modal hosting implementation and did not provide a guarded, reversible Stage 5 cutover mechanism.
Validation
Fixes #3775