Skip to content

Remove brittle changelog architecture test - #3790

Merged
anth-volk merged 1 commit into
masterfrom
agent/remove-brittle-changelog-test
Aug 12, 2026
Merged

Remove brittle changelog architecture test#3790
anth-volk merged 1 commit into
masterfrom
agent/remove-brittle-changelog-test

Conversation

@anth-volk

Copy link
Copy Markdown
Collaborator

Fixes #3789

Summary

  • remove the wording-only test that reads a specific Towncrier fragment
  • preserve the behavioral architecture guards for service-owned sessions
  • add a changelog fragment for this fix

Root cause

The test assumed changelog.d/3788.changed.md would remain in the repository. Towncrier correctly consumes and deletes that fragment in the generated release commit, so the post-release deployment test run failed with FileNotFoundError despite the architecture behavior remaining valid.

Validation

  • .venv/bin/pytest tests/unit/services/test_service_owned_session_architecture.py -q (13 passed)
  • git diff --check

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.19%. Comparing base (3b3daeb) to head (354903f).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3790   +/-   ##
=======================================
  Coverage   84.19%   84.19%           
=======================================
  Files          86       86           
  Lines        4720     4720           
  Branches      926      926           
=======================================
  Hits         3974     3974           
  Misses        510      510           
  Partials      236      236           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anth-volk
anth-volk marked this pull request as ready for review August 12, 2026 16:14
@anth-volk
anth-volk merged commit 5ef2c01 into master Aug 12, 2026
11 checks passed
@anth-volk
anth-volk deleted the agent/remove-brittle-changelog-test branch August 12, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove brittle changelog-fragment architecture test

1 participant