Skip to content

API Architecture doc blog post#2345

Merged
MaxGhenis merged 1 commit intomasterfrom
2344_publish_api_architecture
Feb 12, 2025
Merged

API Architecture doc blog post#2345
MaxGhenis merged 1 commit intomasterfrom
2344_publish_api_architecture

Conversation

@mikesmit
Copy link
Collaborator

@mikesmit mikesmit commented Feb 6, 2025

fixes #2344

  1. Created an article on the new design
  2. added myself and a photo of me as an author
  3. added the article to the manifest

@mikesmit mikesmit requested a review from MaxGhenis February 6, 2025 16:33
@vercel
Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
policyengine-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 9:27pm

Copy link
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mikesmit, thanks for your work on this. I limited the scope of my review to the technical implementation, as Max would be responsible for language, but did note a required change before we can merge.

Copy link
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @mikesmit! If you could just run the linter and merge, pending approval of the content, this will be good to merge.

Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run make format to pass lint? Please also confirm you tested it locally.

@mikesmit
Copy link
Collaborator Author

I tested by running it locally and looking at the article in my local browser (I.e. make debug).
Screenshot 2025-02-11 13 23 55
Screenshot 2025-02-11 13 23 34
Screenshot 2025-02-11 13 23 23

@MaxGhenis MaxGhenis merged commit 72e1ebb into master Feb 12, 2025
4 checks passed
@MaxGhenis MaxGhenis deleted the 2344_publish_api_architecture branch February 12, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Publish target API architecture on blog

3 participants