Skip to content

Added abolitions filter in API Variable/Parameter Explorer#2596

Merged
anth-volk merged 4 commits into
PolicyEngine:masterfrom
harnish7576:harnish7576/issue2486_subissue_2488_adding_abolitions_filter
Jul 7, 2025
Merged

Added abolitions filter in API Variable/Parameter Explorer#2596
anth-volk merged 4 commits into
PolicyEngine:masterfrom
harnish7576:harnish7576/issue2486_subissue_2488_adding_abolitions_filter

Conversation

@harnish7576
Copy link
Copy Markdown
Collaborator

@harnish7576 harnish7576 commented Jun 2, 2025

Fixes #2488

Description

Adds toggle-based filtering to show or hide parameters related to "abolition" in the parameter explorer.

Changes

  • Introduced filterByAbolition toggle logic.
  • Filter excludes gov.abolitions* items unless toggle is enabled.

Screenshots

Screenshot 2025-06-06 at 5 49 52 PM

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
policyengine-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2025 6:05pm

Copy link
Copy Markdown
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harnish7576, this is a great start. I wanted to propose a subtle reframing of the feature, then review visuals next time around.

Comment thread src/pages/learn/APIGeneralContent.jsx Outdated
@github-project-automation github-project-automation Bot moved this from Todo to PR: Review Requested in policyengine-app Jun 5, 2025
@MaxGhenis
Copy link
Copy Markdown
Contributor

Please use the keyword as needed to link https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue

@MaxGhenis
Copy link
Copy Markdown
Contributor

Still not linked; remove "issue"
image

@harnish7576
Copy link
Copy Markdown
Collaborator Author

@MaxGhenis Ahh, now I get it — I thought adding the issue number with a hashtag would auto-link it. Thanks for pointing it out!

Copy link
Copy Markdown
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harnish7576 Thanks for your continued work on this. There's one minor blocking change, and it'd be appreciated if you could add/modify a Jest test for the modified component, then we'll be good to merge.

Comment thread src/pages/learn/APIGeneralContent.jsx Outdated
Comment thread src/pages/learn/APIGeneralContent.jsx Outdated
Copy link
Copy Markdown
Collaborator

@anth-volk anth-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @harnish7576! I have one minor nit, but non-blocking. Address or not, then flag for me to merge and we can get this in.

Comment thread src/pages/learn/APIGeneralContent.jsx Outdated
@anth-volk anth-volk merged commit 5ae0185 into PolicyEngine:master Jul 7, 2025
4 checks passed
@github-project-automation github-project-automation Bot moved this from PR: Review Requested to Done in policyengine-app Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Filter abolitions folder out from API variables and parameters explorer and allow toggle to display

3 participants