Fix silent weight-save failure in non-verbose calibrate branch#348
Merged
Fix silent weight-save failure in non-verbose calibrate branch#348
Conversation
Contributor
Author
|
Self-review: APPROVE. See |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calibrate_local_areashad itsif epoch % 10 == 0save block indented outside thefor epoch in range(epochs):loop in the non-verbose branch ofpolicyengine_uk_data/utils/calibrate.py.epoch = epochs - 1. For the defaultepochs=512that isepoch=511, and511 % 10 != 0, so the weights h5 file was silently never written on local runs.This PR:
policyengine_uk_data/tests/test_calibrate_save.pywith a regression test that drivescalibrate_local_areaswith tiny toy inputs andepochs=5(soepoch=4 % 10 != 0— a value that fails on the broken code but passes with the fix).No changes to call sites or public API.
Test plan
uv run pytest policyengine_uk_data/tests/test_calibrate_save.py -xpasses with the fix.calibrate.pychange and rerunning the test reliably fails with "calibrate_local_areas did not write the weight file".Reported as finding U1 in an external bug hunt on
policyengine-uk-data.