Guard income imputation rescale against zero-total baseline#350
Merged
Guard income imputation rescale against zero-total baseline#350
Conversation
Contributor
Author
|
Self-review: APPROVE. See |
af8315c to
5b1034d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
impute_over_incomesinpolicyengine_uk_data/datasets/imputations/income.pycomputednew_income_total / original_income_totalwith no guard for the case whereoriginal_income_total == 0. That case is reachable from withinimpute_incomeitself, where thezero_weight_copydataset is constructed specifically so its imputation columns contribute nothing — and it will become more common as additional callers ofimpute_over_incomesland.Before:
ZeroDivisionError(or silent NaN/inf propagating into household rent and mortgage columns).After:
_safe_rescale_factor(original, new)returns1.0when the baseline is zero (leaves rent/mortgage untouched), otherwise returnsnew / originalas before.Test plan
uv run pytest policyengine_uk_data/tests/test_income_rescale_factor.py -qpasses.Finding U3 from the bug hunt.