Skip to content

Harden UK data release manifest finalization#397

Merged
MaxGhenis merged 3 commits into
mainfrom
harden-manifest-finalization-contract
May 9, 2026
Merged

Harden UK data release manifest finalization#397
MaxGhenis merged 3 commits into
mainfrom
harden-manifest-finalization-contract

Conversation

@anth-volk
Copy link
Copy Markdown
Contributor

Fixes #396

Summary

  • Treat the versioned releases/<version>/release_manifest.json at the HF tag as the authoritative finalized bundle contract.
  • Add strict release manifest validation for artifact hashes, sizes, defaults, build metadata, exact UK package compatibility, and exact core compatibility.
  • Make finalized upload retries idempotent only when the rebuilt candidate manifest exactly matches the finalized manifest.
  • Hard-fail existing tags that lack a versioned manifest or whose manifest differs from the candidate.
  • Add a changelog fragment.

Testing

  • python -m pytest policyengine_uk_data/tests/test_release_manifest.py -q passed locally: 22 passed, 1 skipped because policyengine-bundles is not installed locally.
  • ruff check policyengine_uk_data/utils/release_manifest.py policyengine_uk_data/utils/data_upload.py policyengine_uk_data/tests/test_release_manifest.py passed.
  • ruff format --check policyengine_uk_data/utils/release_manifest.py policyengine_uk_data/utils/data_upload.py policyengine_uk_data/tests/test_release_manifest.py passed.

Notes

  • This intentionally does not introduce release-complete.json; the release manifest is the release contract.
  • Local Python 3.14 pytest execution was blocked because this macOS x86_64 environment could not resolve a compatible torch==2.9.1 wheel through uv.

@anth-volk anth-volk requested a review from vahid-ahmadi May 8, 2026 01:18
@anth-volk anth-volk marked this pull request as ready for review May 8, 2026 01:19
@MaxGhenis MaxGhenis merged commit 4f7ac9d into main May 9, 2026
4 checks passed
@MaxGhenis MaxGhenis deleted the harden-manifest-finalization-contract branch May 9, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Harden UK data release manifest finalization for bundle consumption

2 participants