Conversation
Use British English spelling throughout the labour supply response module: directory names, file names, parameter labels, descriptions, import paths, and test references. Fixes #853. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Clean rename but it's a breaking API change on an externally-referenced parameter path, so we can't merge standalone.
Merging this as-is will silently break the LSR sliders in the policy sidebar the next time the app rebuilds against a policyengine-uk that has these parameters at Options to unblock:
I'd lean toward (1) — the app reference is only two lines and nothing else external uses these paths (I checked policyengine-api, policyengine-app-v2, policyengine-uk-data, policyengine-core). If you want, I can stage the companion app PR and link it here. Blocking on that decision. |
The UK labour supply response parameters are being renamed from gov.simulation.labor_supply_responses.* to gov.simulation.labour_supply_responses.* in PolicyEngine/policyengine-uk#1607. Update the two UK-only path strings in PolicyRightSidebar so the LSR sliders keep resolving after that merges. US paths unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Going with option 1. Opened the companion app PR: PolicyEngine/policyengine-app#2829. It updates just the two UK-only path strings in Suggested merge order to minimize the breakage window:
Ready for review here once you're happy with the app-side change. |
Summary
labortolabour(British English) across all LSR parameter and variable directory names, file names, labels, descriptions, import paths, and test referencesFixes #853
Test plan
gov.simulation.labour_supply_responses.*)pytest policyengine_uk/tests/test_labour_supply_response_formulas.py -vpytest policyengine_uk/tests/test_behavioral_responses.py -v🤖 Generated with Claude Code