Fix UC childcare work condition for couples#1757
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EFRS oracle evidence
Using the new Axiom RuleSpec Regulation 32 surface over the local enhanced FRS:
policyengine-uk==2.88.42: 5,996 mismatches out of 61,858 benefit unitsThe mismatches are all cases where current PE returns true for the childcare work condition while RuleSpec returns false, consistent with the existing formula using
any(adults_in_work)instead of requiring all adults in the benefit unit to be in work.Tests
uv run policyengine-core test policyengine_uk/tests/policy/baseline/finance/benefit/family/universal_credit/childcare_element/uc_childcare_work_condition.yaml -c policyengine_ukuv run policyengine-core test policyengine_uk/tests/policy/baseline/finance/benefit/family/universal_credit/childcare_element -c policyengine_ukuv run ruff check policyengine_uk/variables/gov/dwp/universal_credit/childcare_element/uc_childcare_work_condition.pyuv run ruff format --check policyengine_uk/variables/gov/dwp/universal_credit/childcare_element/uc_childcare_work_condition.pygit diff --check