Fix Stage 1 publication validation gates#1005
Merged
Merged
Conversation
5ff5283 to
97de249
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1004
Supersedes #980 by bringing Daphne's Medicaid Stage 1 target alignment into this branch, so the publication pipeline has one PR and one CI result to merge.
Summary
Failure context
Main-branch Modal run
usdata-gha26017052902-a1built Stage 1 artifacts but failedpytest validation/stage_1/in appus-data-1-115-2-patch-usdata-gha26017052902-a1. The original failures were ACA state-target checks, formula-storage export-contract checks, and additive target-expression checks. #1003 fixed the latter two classes on main; this PR covers the ACA target concept and Medicaid target alignment, with loose state-level gates to avoid blocking publication on known noisy calibration diagnostics.Verification
uv run --no-sync ruff check validation/stage_1/aca_calibration.py validation/stage_1/test_enhanced_cps.py validation/stage_1/test_sparse_enhanced_cps.py validation/stage_1/conftest.py tests/unit/calibration/test_loss_targets.pyuv run --no-sync pytest tests/unit/calibration/test_loss_targets.py::test_medicaid_targets_roll_forward_to_2025 tests/unit/calibration/test_loss_targets.py::test_medicaid_national_targets_use_2025_values -quv run --no-sync pytest validation/stage_1/test_no_formula_variables_stored.py::test_no_formula_variables_stored validation/stage_1/test_policy_data_db.py::test_all_target_variables_exist_in_policyengine -quv run --no-sync pytest validation/stage_1/test_enhanced_cps.py::test_aca_calibration validation/stage_1/test_enhanced_cps.py::test_medicaid_calibration validation/stage_1/test_sparse_enhanced_cps.py::test_sparse_aca_calibration validation/stage_1/test_sparse_enhanced_cps.py::test_sparse_medicaid_calibration -qagainst the failed run's downloadedenhanced_cps_2024.h5,extended_cps_2024.h5, andpolicy_data.dbartifacts: 4 passed.