Fix remaining CI issues #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove processed changelog_entry.yaml that was left after PR merge - Remove unused make_person function that referenced undefined CURRENT_YEAR
MaxGhenis
force-pushed
the
fix-remaining-ci-issues
branch
from
4dc170d to
f978881
Compare
- Create reusable workflows for changelog validation, linting, and testing - Update PR changelog workflow to validate format (not just existence) - Ensure PR and push workflows use same core logic - Only difference is push workflow uploads data and deploys docs
juaristi22
pushed a commit
that referenced
this pull request
Aug 8, 2025
* Fix push CI issues - Remove processed changelog_entry.yaml that was left after PR merge - Remove unused make_person function that referenced undefined CURRENT_YEAR * Add changelog entry for CI fix * Modularize CI workflows for consistency between PR and push - Create reusable workflows for changelog validation, linting, and testing - Update PR changelog workflow to validate format (not just existence) - Ensure PR and push workflows use same core logic - Only difference is push workflow uploads data and deploys docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the push CI issues that occurred after merging #117:
Changes
changelog_entry.yamlthat was left in the repository after PR Add comparative dataset analysis to paper #117 was mergedmake_personfunction that referenced undefinedCURRENT_YEARvariableContext
The difference between PR CI and push CI is that push CI runs additional steps including changelog/versioning builds. The leftover changelog entry was causing the push CI to fail.