Fix ACA PTC state calibration targets#892
Merged
Merged
Conversation
MaxGhenis
approved these changes
May 5, 2026
Contributor
MaxGhenis
left a comment
There was a problem hiding this comment.
Fixed the Towncrier fragment path and rechecked the rerun. All PR checks are green, including integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aca_ptcfrom85530to85770so it targets total premium tax credit instead of Additional Medicare Tax.aca_ptc_state.csvfrom IRS SOI Historical Table 2 (N85770/A85770) plus a refresh script and loader that applies the checked-in 2022-to-target-year ACA PTC multipliers.publish_local_area.py, matchingentity_clone.py, so non-ASCII counties likeDOÑA_ANA_COUNTY_NMdo not fail dataset loading.Fixes #805.
Diagnostics
Baseline all-state diagnostic on the staged 1.89.1 state files showed Florida as the only major enrollment impossibility: target 4.47M APTC people vs 2.96M modeled positive-PTC potential people (-33.8%). New Mexico failed to load because the staged H5 stored
DOÑA_ANA_COUNTY_NMas UTF-8 bytes.After applying the SOI/uprated target path, the 17-state problem slice shows NY/DC/MN are no longer the scary cases under assigned takeup spending:
So the remaining work is concentrated in real modeled composition/potential gaps, especially FL/TX/GA, rather than NY/MN/BHP target-definition weirdness.
Tests
.venv/bin/ruff check ....venv/bin/python -m pytest tests/unit/test_aca_ptc_targets.py tests/unit/calibration/test_publish_local_area.py tests/unit/calibration/test_entity_clone.py tests/unit/test_refresh_aca_ptc_state_targets.py tests/unit/test_enhanced_cps.py tests/unit/calibration/test_loss_targets.py tests/unit/test_etl_irs_soi_overlay.py -quv run pytest tests/integration/test_build_h5.py -q