Add to PR template#424
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
==========================================
+ Coverage 95.20% 95.25% +0.04%
==========================================
Files 62 61 -1
Lines 3859 3896 +37
Branches 493 495 +2
==========================================
+ Hits 3674 3711 +37
Misses 160 160
Partials 25 25
Continue to review full report at Codecov.
|
MaxGhenis
reviewed
Dec 31, 2021
PavelMakarchuk
added a commit
that referenced
this pull request
May 14, 2026
…ld (#8293) * Fix AMT capital-gains overflow into the 20% bracket below the threshold Form 6251 Part III Line 27 references the regular-tax ordinary-income portion (QDCG Worksheet line 5 or Schedule D Tax Worksheet line 21). The code instead read `loss_limited_net_capital_gains` (the LTCG amount itself), which shrank the 15% bracket window and pushed gains into the 20% bracket even when AMTI minus exemption sat far below the $583,750 MFJ threshold. Line 23 was also storing the tax (= $0 at the current 0% rate) instead of the amount, which the form re-uses in Line 24 and Line 32. Both errors compounded across all years 2018-2025. Switching Line 23 to the amount and Line 27 to `dwks14` (already used for Line 20) restores faithful Form 6251 math. Updated three existing tests that locked in the pre-fix output and added an integration test reproducing the taxsim #424 case. Fixes #8292 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Add Form 6251 Part III boundary tests for AMT cap-gains fix Five new cases exercise: - 0% bracket threshold (entire base in 0%) - 20% bracket threshold (entire base at 15%) - Above 20% threshold (real 20% bracket usage) - Mixed preferential + non-zero regular-tax ordinary income (locks in the Line 27 fix specifically) - Joint filer with substantial cap gains below joint 20% threshold Each test's expected value was manually computed from Form 6251 Part III line-by-line and matches PE output to the cent. All 60 AMT tests and 821 federal-income tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #422
Fixes #423