Skip to content

Conversation

@baogorek
Copy link
Collaborator

@baogorek baogorek commented May 22, 2025

Closes #6068

New QBID Variables are necessary to do the computations we want to do.

The Larger Plan. Complete in this order:

  1. THIS ONE - policyengine-us: QBID Variables Only # 6031 - there's no logic in here. Just variables
  2. policyengine-us-data: QBID Variables added #256 - We need 1 in before we can pass these tests
  3. policyengine-us: QBID formula Logic and Tests #6067 - relies on the first two, but now we're down to 7 files

Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while here can we refactor to add some intermediate variables? we generally try to keep each under ~50 lines, these are 100+

@baogorek baogorek marked this pull request as ready for review May 28, 2025 14:16
@baogorek baogorek changed the title QBID variables and updated formulas QBID variables only May 29, 2025
@baogorek baogorek self-assigned this May 29, 2025
Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge after these

@baogorek baogorek requested a review from MaxGhenis May 30, 2025 13:11
@baogorek baogorek merged commit 26e569e into master May 30, 2025
3 checks passed
@baogorek baogorek deleted the BenOgorek/qbid-suite branch May 30, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add variables related to QBID and bring adjacent income variables into compliance with standards

4 participants