-
Notifications
You must be signed in to change notification settings - Fork 201
QBID variables only #6031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
QBID variables only #6031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelMakarchuk
requested changes
May 22, 2025
policyengine_us/parameters/gov/irs/deductions/qbi/income_definition.yaml
Outdated
Show resolved
Hide resolved
PavelMakarchuk
requested changes
May 25, 2025
…asses-into-individual-files Refactor input income variables
… BenOgorek/qbid-suite
MaxGhenis
requested changes
May 26, 2025
Contributor
MaxGhenis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while here can we refactor to add some intermediate variables? we generally try to keep each under ~50 lines, these are 100+
policyengine_us/variables/household/income/person/farm/farm_rent_income.py
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/contrib/reconciliation/qbid/use_bdc_income.yaml
Outdated
Show resolved
Hide resolved
policyengine_us/parameters/gov/contrib/reconciliation/qbid/use_bdc_income.yaml
Outdated
Show resolved
Hide resolved
baogorek
commented
May 26, 2025
.../gov/irs/income/taxable_income/deductions/qualified_business_income_deduction/qbid_amount.py
Outdated
Show resolved
Hide resolved
…ces-to-missing-files Add anchor refs for QBI deduction
…variables-to-tax-form Add form references for QBID inputs
…siness-income-variables Add qualified business income adjustments
…or-199a-variables Fix uprating for QBI incomes
PavelMakarchuk
requested changes
May 27, 2025
…tests Format files with black
… BenOgorek/qbid-suite
…nto-separate-files Split income input variables into separate files
MaxGhenis
approved these changes
May 30, 2025
Contributor
MaxGhenis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to merge after these
…ry.yaml-for-qbid-variables Update changelog for QBID variables
PavelMakarchuk
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6068
New QBID Variables are necessary to do the computations we want to do.
The Larger Plan. Complete in this order: