Add education credit eligibility inputs#8170
Open
MaxGhenis wants to merge 3 commits intoPolicyEngine:mainfrom
Open
Add education credit eligibility inputs#8170MaxGhenis wants to merge 3 commits intoPolicyEngine:mainfrom
MaxGhenis wants to merge 3 commits intoPolicyEngine:mainfrom
Conversation
This was referenced Apr 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8170 +/- ##
===========================================
- Coverage 100.00% 95.53% -4.47%
===========================================
Files 3 25 +22
Lines 39 291 +252
Branches 0 4 +4
===========================================
+ Hits 39 278 +239
- Misses 0 11 +11
- Partials 0 2 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4cb43ae to
37bf0fb
Compare
37bf0fb to
605ddc3
Compare
Contributor
Author
|
Local paired build result using this PE-US branch with PolicyEngine/policyengine-us-data#843:
Calibration log from the local build:
There is no standalone LLC calibration target in this pair because IRS SOI Table 3.3 reports LLC only inside the combined nonrefundable education credit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_eligible_for_american_opportunity_creditfrom those predicates instead of leaving it as an unpopulated inputis_eligible_for_lifetime_learning_creditwhile continuing to exclude AOTC-eligible students from LLC expensesPrimary Sources
Tests
uv run ruff format policyengine_us/variables/gov/irs/credits/education policyengine_us/tests/policy/baseline/gov/irs/credits/education/lifetime_learning_credituv run ruff check policyengine_us/variables/gov/irs/credits/education policyengine_us/tests/policy/baseline/gov/irs/credits/education/lifetime_learning_credituv run python -m policyengine_core.scripts.policyengine_command test policyengine_us/tests/policy/baseline/gov/irs/credits/education -c policyengine_usFollow-up data PR: PolicyEngine/policyengine-us-data#843