Add fiscal diagnostics comparison tool#190
Merged
Merged
Conversation
1c9bda3 to
d20a117
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calibration_diagnostics.jsonfiles on a strictly shared target surfaceValidation
uv run ruff format tools/compare_us_fiscal_diagnostics.py packages/populace-build/tests/test_compare_us_fiscal_diagnostics.pyuv run ruff check tools/compare_us_fiscal_diagnostics.py packages/populace-build/tests/test_compare_us_fiscal_diagnostics.pyuv run python -m pytest packages/populace-build/tests/test_compare_us_fiscal_diagnostics.pyReal comparison guardrail
A previous candidate/incumbent smoke used diagnostics with overlapping target names but changed capital-gains target values. The tool now correctly rejects that comparison with
ValueError: Cannot compare diagnostics with changed shared target values. The incumbent must be rescored on the exact candidate/current target surface before using this tool for release certification.