Skip to content

feat(pc-keyboard): Octave shift on z/x press & layout independent key handling - #417

Merged
PolyMeilex merged 1 commit into
masterfrom
pc-keys-shift-my-take
Aug 4, 2026
Merged

feat(pc-keyboard): Octave shift on z/x press & layout independent key handling#417
PolyMeilex merged 1 commit into
masterfrom
pc-keys-shift-my-take

Conversation

@PolyMeilex

@PolyMeilex PolyMeilex commented Aug 4, 2026

Copy link
Copy Markdown
Owner
  • z x Can now shift PcKeyboard octave
  • The octave shift is saved in the config
  • While at it the key handling was changed to be keyboard layout independent

@kasimeka

kasimeka commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

this makes a lot more sense in the context of the repo and i feel like an idiot for my PR😅
and yes it works great with my dvorak layout

@kasimeka

kasimeka commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

can i get my nix flake merged tho? would love to run the app with nix run github:PolyMeilex/Neothesia instead of cloning the repo / downloading a release

@kasimeka

kasimeka commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

any intention to implement the guess an octave shift near the center of the piano range logic tho?

@PolyMeilex

Copy link
Copy Markdown
Owner Author

i feel like an idiot for my PR

No problem, it still makes the implementation easier for me when I have a POC to go of off.

can i get my nix flake merged tho?

Sure, that might be useful for other people too.

any intention to implement the guess an octave shift near the center of the piano range logic tho?

Yeah, I just wonder how to do that best in the context of me adding the "remember last setting" logic. Perhaps the remember logic is not that usefull tho.

@PolyMeilex
PolyMeilex merged commit bf30218 into master Aug 4, 2026
6 checks passed
@PolyMeilex
PolyMeilex deleted the pc-keys-shift-my-take branch August 4, 2026 20:26
@kasimeka

kasimeka commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

in the context of me adding the "remember last setting" logic

i think overwriting the saved octave shift with the calculated value only after piano range settings are changed, and otherwise keeping the saved value intact would be reasonable

@PolyMeilex

Copy link
Copy Markdown
Owner Author

i think overwriting the saved octave shift with the calculated value only after piano range settings are changed, and otherwise keeping the saved value intact would be reasonable

Sounds good. I will recalculate it on every range change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants