Fix some more sentry issue - #143
Merged
Merged
Conversation
# Conflicts: # src/main/kotlin/org/polyfrost/polyplus/client/network/eos/EosSdkBridgeImpl.kt
Session refresh no longer throws InterruptedException out of the authenticateServer mixin. Minecraft interrupts its Util.ioPool() worker when the player cancels the connect screen or the client shuts down, and the escaping exception aborted handleHello before setEncryption, stalling the handshake for good. All three blocking sites (beforeAuthenticate, refreshAfterRejection and MinecraftLoginGate.begin) now fail open and restore the interrupt, so vanilla authenticates with the existing token. The join-blocking window is also bounded explicitly instead of relying on performRefresh internals. Menu heads no longer allocate Compose snapshot state during composition. MenuHeadCache created a mutableStateOf on a cache miss inside get() and read it in the same snapshot; it now holds plain values and composables read through rememberMenuHead, which loads outside composition via produceState. Early init hooks are held as factories so that naming an object runs its static initializer inside step(). A repository whose clinit fails no longer throws ExceptionInInitializerError out of the Fabric entrypoint and takes the game down before the main menu. Stack overflow crash reports are captured on a dedicated thread with its own stack, so classloading on the report path cannot overflow a second time and lose the report. Ignore versions/*/PolyPlus/, the client run directory PolyPlus caches panorama packs into. Fixes POLYPLUS3-12Y Fixes POLYPLUS3-225 Fixes POLYPLUS3-29E Fixes POLYPLUS3-1XG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes POLYPLUS3-12Y
Fixes POLYPLUS3-225
Fixes POLYPLUS3-29E
Fixes POLYPLUS3-1XG