Skip to content

Optimise node id filters when used as graph view - #2690

Merged
ljeub-pometry merged 1 commit into
db_v4from
optimise_node_filtered_graph
Jul 29, 2026
Merged

Optimise node id filters when used as graph view#2690
ljeub-pometry merged 1 commit into
db_v4from
optimise_node_filtered_graph

Conversation

@ljeub-pometry

Copy link
Copy Markdown
Collaborator

What changes were proposed in this pull request?

NodeFilteredGraph was not calling the domain on the filter when computing the node list, resulting in sub-optimal traversals when using node id filters as a graph view.

Why are the changes needed?

performance

Does this PR introduce any user-facing change? If yes is this documented?

no

How was this patch tested?

Are there any further changes required?

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 64b5001 Previous: 9823ef7 Ratio
lotr_graph/num_edges 4 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph/num_nodes 6 ns/iter (± 0) 1 ns/iter (± 0) 6
lotr_graph/graph_latest 3 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph_materialise/materialize 7712938 ns/iter (± 42213) 1564816 ns/iter (± 35303) 4.93
lotr_graph_window_100/num_nodes 15 ns/iter (± 0) 5 ns/iter (± 0) 3
lotr_graph_window_100_materialise/materialize 7935001 ns/iter (± 76361) 1669150 ns/iter (± 10700) 4.75
lotr_graph_window_10/has_node_existing 137 ns/iter (± 10) 62 ns/iter (± 11) 2.21
lotr_graph_window_10_materialise/materialize 3314627 ns/iter (± 12668) 971980 ns/iter (± 4278) 3.41
lotr_graph_subgraph_10pc_materialise/materialize 2136424 ns/iter (± 25180) 334634 ns/iter (± 1287) 6.38
lotr_graph_subgraph_10pc_windowed/has_node_existing 139 ns/iter (± 11) 62 ns/iter (± 14) 2.24
lotr_graph_subgraph_10pc_windowed_materialise/materialize 1262883 ns/iter (± 10885) 230399 ns/iter (± 2617) 5.48
lotr_graph_window_50_layered/num_edges_temporal 146014 ns/iter (± 1313) 70121 ns/iter (± 7586) 2.08
lotr_graph_window_50_layered/has_node_existing 372 ns/iter (± 22) 129 ns/iter (± 12) 2.88
lotr_graph_window_50_layered/graph_latest 86850 ns/iter (± 7436) 36649 ns/iter (± 916) 2.37
lotr_graph_window_50_layered_materialise/materialize 28977953 ns/iter (± 124489) 3488825 ns/iter (± 24948) 8.31
lotr_graph_persistent_window_50_layered/num_edges_temporal 580477 ns/iter (± 17354) 192686 ns/iter (± 1569) 3.01
lotr_graph_persistent_window_50_layered/has_node_existing 420 ns/iter (± 381) 174 ns/iter (± 83) 2.41
lotr_graph_persistent_window_50_layered/graph_latest 131034 ns/iter (± 2153) 57549 ns/iter (± 4809) 2.28
lotr_graph_persistent_window_50_layered_materialise/materialize 50475630 ns/iter (± 757096) 5298035 ns/iter (± 147912) 9.53

This comment was automatically generated by workflow using github-action-benchmark.

@ljeub-pometry
ljeub-pometry merged commit 26237ed into db_v4 Jul 29, 2026
34 checks passed
@ljeub-pometry
ljeub-pometry deleted the optimise_node_filtered_graph branch July 29, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants