Tweaked build setups - omit rollup warnings, annotate pure calls & more - #340
Merged
Conversation
Collaborator
|
I've merged but gonna have to remove the |
Collaborator
|
Oh I see this is more for when people consume it as a package? I'll leave it as is for now but will look into a rollup step further down the line to consolidate this logic |
Collaborator
|
PS Thanks for the PR 😅 |
Contributor
Author
Yeah, exactly 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review this carefully, I've done those changes quickly & I have no actual knowledge about this project (I have not yet used it, although I'm planning to 😉 ). As always - if something is unclear, please ask about it and I'll try my best to explain the change in question.