perf(thread): stabilize goal dock state and floor elapsed seconds - #690
Merged
Conversation
- Reuse cached dock-state refs when unrelated chat items arrive - Key goal timer effects on timing fields, not state identity - Floor elapsed seconds so the bubble does not tick early - Add selector stability and elapsed-second unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the goal bubble timer ticking faster than real time and re-rendering on every streamed chat message.
Tests: new threadGoalTiming.test.ts + selector stability tests in threadGoalState.test.ts; full src/renderer/components/thread suite green (933 passed); typecheck/lint/fmt clean.