fix(mcp): treat expired OAuth tokens as signed out and hint ACP re-auth - #693
Merged
Conversation
- Report MCP URLs as authenticated only when tokens are valid or refreshable - Append a re-auth/new-thread hint to ACP prompt failures on MCP 401/Unauthorized - Cover expired-token status and ACP hint behavior in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes intermittent Antigravity ACP turn failures (
MCP load failed for Vercel ... Unauthorized) seen on long-lived threads while MCP settings still shows Connected.McpOAuthService.status()no longer reports expired access tokens without a refresh token as authenticated, so the UI prompts re-auth instead of showing a stale Connected badge.resolveAcpPromptFailureMessage(shared ACP path) appends an actionable hint to MCP 401/Unauthorized turn failures, naming the server when parseable and advising re-auth + a new thread (ACP sessions snapshot MCP headers at session open; generic ACP has no per-turn refresh).Tests:
McpOAuthService.test.ts(+2),session.test.ts(+3).typecheck,lint,fmtclean.