fix: kill_on_drop on firebird, mariadb, mysql, redis, valkey

[RambokDev]

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability of database and cache health checks by automatically terminating background ping processes when checks are cancelled or abandoned.
  • Prevents lingering Firebird, MySQL, MariaDB, Redis, and Valkey processes from consuming resources.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: cd7cb8e7-e158-4fb5-b572-f5d05da22d77

📥 Commits

Reviewing files that changed from the base of the PR and between f7f5f7e and 0a53eec.

📒 Files selected for processing (5)

• src/domain/firebird/ping.rs
• src/domain/mariadb/ping.rs
• src/domain/mysql/ping.rs
• src/domain/redis/ping.rs
• src/domain/valkey/ping.rs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The database ping commands now set kill_on_drop(true) for Firebird, MariaDB, MySQL, Redis, and Valkey subprocesses. Dropping or cancelling a command terminates its child process.

Changes

Ping subprocess lifecycle handling

Layer / File(s)	Summary
Configure ping command cleanup src/domain/firebird/ping.rs, src/domain/mariadb/ping.rs, src/domain/mysql/ping.rs, src/domain/redis/ping.rs, src/domain/valkey/ping.rs	Each ping command enables kill_on_drop(true) so its child process is terminated when the command handle is dropped.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 0a53e

This localized change ensures dropped database and cache probe processes are terminated; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 5 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: enabling kill_on_drop for the Firebird, MariaDB, MySQL, Redis, and Valkey ping commands.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/kill-on-drop

Warning

Some tools did not complete. Review the errors below.

🔧 Clippy (1.97.1)

Clippy execution timed out

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!