Skip to content

dev#86

Merged
RambokDev merged 3 commits into
mainfrom
dev
Jul 21, 2026
Merged

dev#86
RambokDev merged 3 commits into
mainfrom
dev

Conversation

@RambokDev

@RambokDev RambokDev commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Storage uploads can now be placed in a configured destination folder across local and cloud storage providers.
    • Folder names are cleaned up automatically, with backups used when no custom folder is specified.
  • Bug Fixes

    • Improved consistency of reported upload paths when custom storage folders are configured.
  • Tests

    • Added coverage for default and custom upload folder paths.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@RambokDev, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c5c4373c-30aa-4ea8-9104-88751f3b4dee

📥 Commits

Reviewing files that changed from the base of the PR and between 37b4c1f and c186d57.

📒 Files selected for processing (2)
  • .github/workflows/ghcr.yml
  • .github/workflows/release.yml
📝 Walkthrough

Walkthrough

Storage configuration now accepts an optional folder name, normalizes it in the shared path builder, and propagates it to Azure, GCS, Google Drive, local, and S3 uploads. Tests cover default and custom folders. Docker Compose also updates EDGE_KEY and commented temporary-directory lines.

Changes

Folder-aware storage paths

Layer / File(s) Summary
Path builder contract
src/utils/file.rs, src/tests/utils/file_tests.rs
full_file_path accepts an optional folder, defaults to backups, normalizes separators and whitespace, and is tested with default and custom folders.
Provider path propagation
src/services/api/models/agent/status.rs, src/services/storage/providers/*
DatabaseStorage deserializes optional folderName, and upload providers include it when constructing remote paths.

Compose environment update

Layer / File(s) Summary
Rust service configuration
docker-compose.yml
The rust-app service changes EDGE_KEY and adjusts commented temporary-directory lines.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • Portabase/agent#62: Updates the rust-app service’s EDGE_KEY value in docker-compose.yml.
  • Portabase/agent#83: Changes the shared file-path builder, storage configuration, and upload provider destination paths.
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title is too generic and does not describe the actual changes to storage path handling and folder_name support. Replace it with a concise summary of the main change, e.g. "Support configurable storage folders in upload paths".
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docker-compose.yml`:
- Line 24: Remove the hardcoded EDGE_KEY value from the Compose configuration
and replace it with deployment-environment injection, such as an
environment-variable reference. Ensure src/settings.rs and src/core/context.rs
continue receiving the key through the existing EDGE_KEY configuration, and
rotate or revoke the currently committed credential.

In `@src/utils/file.rs`:
- Around line 50-57: Validate the folder name once in full_file_path: reject
control characters, dot segments, and unsupported separators, or explicitly
canonicalize nested paths before constructing the provider path;
src/utils/file.rs lines 50-57 require this change. In
src/services/storage/providers/local.rs line 41, handle HeaderValue::from_str
failure explicitly and remove the downstream unwrap panic.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 26022c90-f7b4-4afe-926e-eb626950bb78

📥 Commits

Reviewing files that changed from the base of the PR and between 82ffb71 and 37b4c1f.

📒 Files selected for processing (9)
  • docker-compose.yml
  • src/services/api/models/agent/status.rs
  • src/services/storage/providers/azure_blob/mod.rs
  • src/services/storage/providers/google_cloud_storage/mod.rs
  • src/services/storage/providers/google_drive/mod.rs
  • src/services/storage/providers/local.rs
  • src/services/storage/providers/s3/mod.rs
  • src/tests/utils/file_tests.rs
  • src/utils/file.rs

Comment thread docker-compose.yml
Comment thread src/utils/file.rs
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@RambokDev
RambokDev merged commit 90d55f7 into main Jul 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants