Skip to content

feat: sync CLI registry with memory type + categories - #43

Open
nsollazzo wants to merge 6 commits into
mainfrom
feat/cli-memory-categories
Open

feat: sync CLI registry with memory type + categories#43
nsollazzo wants to merge 6 commits into
mainfrom
feat/cli-memory-categories

Conversation

@nsollazzo

Copy link
Copy Markdown
Contributor

Summary

  • Add memory to api.ListingTypes (platform order after mcp) → positronick memory search|list|show|install
  • Add shared api.ListingCategories including Memory and Observability; mockadmin validates against it
  • Update skill contract, README, MCP tools/docs, admin help, CHANGELOG

Why

Platform #163 added the memory listing type and Memory/Observability categories. Released CLI v0.1.2 and previous main still omitted them, so install.sh users and even our alpha binary could not talk to the full registry model (unknown command "memory").

Test plan

  • go test ./... -race — all packages PASS
  • TestSkillPinsTargetAndTypeLists — PASS
  • TestListingTypesMatchPlatformOrder / TestListingCategoriesMatchPlatformOrder
  • Smoke: built binary memory list --json --base-url https://positronick.com{"count":0,"listings":[]} (not unknown command)
  • Existing mcp list still works against prod

Follow-ups (not this PR)

  • Tag v0.1.3 after merge so install.sh leaves v0.1.2
  • Engine ListingTypes still missing memory — separate PR on Positronick/engine
  • Optional later: pass ?q= / ?category= through to server listings API

Notes

  • No promote/billing CLI surface (YAGNI)
  • Does not change existing JSON shapes except additive memory noun + goldens

Align ListingTypes and ListingCategories with platform LISTING_TYPES /
LISTING_CATEGORIES order (memory after mcp; Memory + Observability categories).
Point mockadmin listingCategories at api.ListingCategories so validation
accepts Memory and Observability in platform order.
Add memory short-help, auto-registered via api.ListingTypes; refresh
agent-docs and MCP tools-list goldens for the new noun and type enum.
Pin the platform type list in SKILL.md, add memory to README usage and
MCP/agent-docs prose, and wire memory install onto the registry noun.
Derive public type-noun list from api.ListingTypes so admin Long help
stays in lockstep with the platform enum.
Record the memory listing noun and Memory/Observability categories under
Unreleased.
@nsollazzo

Copy link
Copy Markdown
Contributor Author

Agent review · Positronick CLI

Reviewer: Daneel (Gate B)
PR: #43 · Head: ef41f41
Skills: grok (implement) · requesting-code-review (local race/smoke) · github product-pr Gate B
Verdict: APPROVE

Models & effort

Role Model Effort / mode
Orchestrator (Daneel) grok-4.5 session
Implementer Grok Build CLI headless --always-approve
Gate A local go test ./... -race + prod smoke n/a
Gate B author grok-4.5 session
Secondary not used

Spec compliance

  • memory in api.ListingTypes after mcp (platform order)
  • api.ListingCategories includes Memory + Observability; mockadmin shared
  • positronick memory noun + skill contract pin
  • No promote CLI / no engine changes (YAGNI)

Tests run

  • go test ./... -race — PASS
  • Built binary: memory list --json against https://positronick.comcount:0 (valid empty; not unknown command)
  • mcp list still works against prod

Blockers

None.

Should-fix

None for merge.

Nits / follow-ups (post-merge)

  1. Tag v0.1.3 so install.sh leaves v0.1.2
  2. Engine ListingTypes still missing memory
  3. golangci-lint local env is go1.25 vs project 1.26.5 — pre-existing toolchain pin, not introduced here

Nick merges. No merge from agent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant