test(webhooks): cover bounded retry and safe dead letters - #476
Open
flowpatch-reliability wants to merge 1 commit into
Open
test(webhooks): cover bounded retry and safe dead letters#476flowpatch-reliability wants to merge 1 commit into
flowpatch-reliability wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75. Links back to the integration-platform parent #34.
This adds the requested deterministic failure-path coverage and tightens the durable record contract:
X-Posnic-Deliveryid (documenting at-least-once duplicate expectations)MAX_ATTEMPTSdeadLetteredAtValidation performed:
node --check api/src/realtime/webhooks.jsnode --check api/tests/unit/realtime/webhooks.test.jsThe container did not include npm, so I could not run the repository Jest command locally.