feat: Refactor agent service #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2025
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 17, 2025
charlesvien
force-pushed
the
feature/refactor-agent-service
branch
from
c2c2813 to
a7d0508
Compare
charlesvien
force-pushed
the
feature/refactor-agent-service
branch
from
3d1e613 to
572ea6c
Compare
Closed
charlesvien
force-pushed
the
feature/refactor-agent-service
branch
from
572ea6c to
c8cab39
Compare
joshsny
approved these changes
Dec 17, 2025
| sessionId: z.string(), | ||
| }); | ||
|
|
||
| // Reconnect session input |
Contributor
There was a problem hiding this comment.
nit: can we remove these comments, they clutter things and don't provide any value?
| )) { | ||
| const event = payload as AgentSessionEventPayload; | ||
| if (event.sessionId === targetSessionId) { | ||
| yield event.payload; |
Contributor
There was a problem hiding this comment.
same here with tracked, do we want to use it?
| const toggleLeftSidebar = useSidebarStore((state) => state.toggle); | ||
| const toggleRightSidebar = useRightSidebarStore((state) => state.toggle); | ||
|
|
||
| const handleOpenSettings = useCallback(() => { |
Contributor
There was a problem hiding this comment.
does this callback do anything if the function itself is a dependency?
Contributor
Author
Merge activity
|
charlesvien
force-pushed
the
feature/refactor-git-service
branch
from
4783537 to
02df823
Compare
charlesvien
force-pushed
the
feature/refactor-agent-service
branch
from
edd3e59 to
046ad2f
Compare
charlesvien
changed the base branch from
feature/refactor-git-service
to
graphite-base/287
charlesvien
force-pushed
the
feature/refactor-agent-service
branch
from
046ad2f to
8b70529
Compare
This was referenced Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.