ui feedback #34
Merged
ui feedback #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jonathanlab
commented
Oct 16, 2025
jonathanlab
commented
- add back folder picker
- differentiate between buttons and text in taskdetail and update repo warning
- improve creatino ui
- add settings to top menu, make icon toggle, add shortcut
jonathanlab
requested review from
joshsny and
k11kirky
and removed request for
joshsny
joshsny
approved these changes
Oct 16, 2025
Contributor
joshsny
left a comment
joshsny
left a comment
There was a problem hiding this comment.
Nice! left a nit about unnecessary effects
| if (!open) { | ||
| setRepoWarning(null); | ||
| } | ||
| }, [open]); |
Contributor
There was a problem hiding this comment.
we control the value of open, so we should be able to avoid this useEffect by moving this to wherever calls onOpenChange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.