Skip to content

feat(code): remove auto-submit from slash commands, fix search#1237

Merged
charlesvien merged 1 commit intomainfrom
03-13-feat_code_remove_auto-submit_from_slash_commands_fix_search
Mar 14, 2026
Merged

feat(code): remove auto-submit from slash commands, fix search#1237
charlesvien merged 1 commit intomainfrom
03-13-feat_code_remove_auto-submit_from_slash_commands_fix_search

Conversation

@adboio
Copy link
Contributor

@adboio adboio commented Mar 13, 2026

problem

  1. when typing to search for a command/skill, the scrolling/filtering does not work
  2. commands are not available in the new task view
  3. commands always nuke and auto-submit your prompt
  4. duplicate skills show up in the list (e.g. one (project)and one (repo-skills-xyz) , they are keyed on name, so multiple skills end up getting highlighted at the same time when searching/filtering and breaking things

changes

  1. fixes scroll/filter when typing to search
  2. adds commands to the new task view
  3. changes to not auto-submit prompts on command selection
  4. deduplicates commands/skills by name
    1. no, this is not a very good solution, but it needs more thinking on how we actually want to handle duplicate commands/skills or their names

Copy link
Contributor Author

adboio commented Mar 13, 2026

@adboio adboio force-pushed the 03-13-feat_code_remove_auto-submit_from_slash_commands_fix_search branch 2 times, most recently from a3d04a3 to 4497e1c Compare March 13, 2026 22:56
@adboio adboio requested a review from a team March 13, 2026 22:57
@adboio adboio marked this pull request as ready for review March 13, 2026 22:57
Copy link
Member

charlesvien commented Mar 14, 2026

Merge activity

  • Mar 14, 7:26 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 14, 7:44 PM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 14, 7:48 PM UTC: @charlesvien merged this pull request with Graphite.

@charlesvien charlesvien changed the base branch from 03-13-chore_code_add_permissions-related_events to graphite-base/1237 March 14, 2026 19:37
@charlesvien charlesvien changed the base branch from graphite-base/1237 to main March 14, 2026 19:42
@charlesvien charlesvien force-pushed the 03-13-feat_code_remove_auto-submit_from_slash_commands_fix_search branch from 4497e1c to 4c18313 Compare March 14, 2026 19:43
@charlesvien charlesvien merged commit 76d9bd0 into main Mar 14, 2026
15 checks passed
@charlesvien charlesvien deleted the 03-13-feat_code_remove_auto-submit_from_slash_commands_fix_search branch March 14, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants