Skip to content

fix: Fix single-select checkbox state in planning mode #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
charlesvien wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −3
Open

fix: Fix single-select checkbox state in planning mode #1312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions apps/code/src/renderer/components/action-selector/useActionSelectorState.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,12 @@ export function useActionSelectorState({
next.add(optionId);
}
} else {
next.clear();
next.add(optionId);
if (next.has(optionId)) {
next.clear();
} else {
next.clear();
next.add(optionId);
}
}
return next;
});
Expand Down Expand Up @@ -227,6 +231,9 @@ export function useActionSelectorState({

if (showSubmitButton) {
if (needsCustomInput(selected) && !isEditing) {
if (!multiSelect) {
setCheckedOptions(new Set());
}
setIsEditing(true);
} else {
toggleCheck(selected.id);
Expand Down Expand Up @@ -330,6 +337,9 @@ export function useActionSelectorState({

if (showSubmitButton) {
if (needsCustomInput(selected)) {
if (!multiSelect) {
setCheckedOptions(new Set());
}
setIsEditing(true);
} else {
toggleCheck(selected.id);
Expand Down Expand Up @@ -382,6 +392,9 @@ export function useActionSelectorState({
const next = new Set(prev);
if (value.trim()) {
if (!prev.has(selectedOption.id)) {
if (!multiSelect) {
next.clear();
}
next.add(selectedOption.id);
}
} else {
Expand All @@ -391,7 +404,7 @@ export function useActionSelectorState({
});
}
},
[showSubmitButton, selectedOption],
[showSubmitButton, selectedOption, multiSelect],
);

const ensureChecked = useCallback((optionId: string) => {
Expand Down
Loading