Use shallow equality in session selector hooks#1358
Merged
jonathanlab merged 1 commit intomainfrom Mar 30, 2026
Merged
Conversation
Zustand selectors use === by default, so derived values like extractAvailableCommandsFromEvents() or fallback empty arrays/Maps cause re-renders even when the contents haven't changed. Adding shallow as the equality function makes these hooks value-aware.
Twixes
force-pushed
the
twixes/stable-empty-selector-refs
branch
from
72ad60b to
4e53b7b
Compare
Twixes
changed the title
jonathanlab
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During agent streaming, the session store fires on every event. Selector hooks like
useAvailableCommandsForTaskderive values (e.g. scanning events backwards for available commands) that return the same contents but a new reference each time. Zustand's default===check sees a different reference and re-renders all subscribers, even though nothing meaningful changed.Changes
Pass
shallowfromzustand/shallowas the equality function on the four hooks that return arrays or Maps. This makes the comparison value-aware — shallow compares array elements and Map entries by reference instead of comparing the container by reference.