feat(code): disable editing in diff viewer#1395
Merged
jonathanlab merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
This was referenced Mar 31, 2026
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
joshsny
approved these changes
Mar 31, 2026
adboio
force-pushed
the
03-31-feat_code_disable_editing_in_diff_viewer
branch
from
d40becd to
f143548
Compare
adboio
force-pushed
the
03-30-feat_code_unified_pr_creation_workflow
branch
from
9e220cd to
4f07e7f
Compare
adboio
force-pushed
the
03-30-feat_code_unified_pr_creation_workflow
branch
from
4f07e7f to
87bd942
Compare
adboio
force-pushed
the
03-31-feat_code_disable_editing_in_diff_viewer
branch
2 times, most recently
from
5a41b00 to
04929ec
Compare
adboio
force-pushed
the
03-30-feat_code_unified_pr_creation_workflow
branch
from
87bd942 to
01efafa
Compare
This was referenced Apr 1, 2026
adboio
force-pushed
the
03-30-feat_code_unified_pr_creation_workflow
branch
2 times, most recently
from
c723cc5 to
c91debf
Compare
adboio
force-pushed
the
03-31-feat_code_disable_editing_in_diff_viewer
branch
from
04929ec to
fabf75a
Compare
graphite-app
bot
changed the base branch from
03-30-feat_code_unified_pr_creation_workflow
to
graphite-base/1395
jonathanlab
approved these changes
Apr 1, 2026
jonathanlab
approved these changes
Apr 1, 2026
jonathanlab
force-pushed
the
graphite-base/1395
branch
from
c91debf to
c010a92
Compare
jonathanlab
force-pushed
the
03-31-feat_code_disable_editing_in_diff_viewer
branch
from
fabf75a to
93e1f08
Compare
jonathanlab
changed the base branch from
graphite-base/1395
to
03-30-feat_code_unified_pr_creation_workflow
jonathanlab
force-pushed
the
03-30-feat_code_unified_pr_creation_workflow
branch
from
c010a92 to
bfeebce
Compare
jonathanlab
force-pushed
the
03-31-feat_code_disable_editing_in_diff_viewer
branch
from
93e1f08 to
05181fa
Compare
Contributor
Merge activity
|
jonathanlab
changed the base branch from
03-30-feat_code_unified_pr_creation_workflow
to
graphite-base/1395
jonathanlab
force-pushed
the
03-31-feat_code_disable_editing_in_diff_viewer
branch
from
05181fa to
949273e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
files can be "edited" in the diff viewer (b side or unified view). the changes are not persisted, but users shouldn't be able to manually edit these in the first place
phc-editing-bug.mp4 (uploaded via Graphite)
Changes
updates diff viewer to disable editing, keeps 'revert' functionality working but removes ability to click/type
notes
i think we probably should allow editing, but since nothing persists right now, it's just confusing so i'm disabling it for now
How did you test this?
manually