fix: Only show "Cancelled" for explicitly cancelled turns#1467
Merged
charlesvien merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 2, 2026
charlesvien
changed the title
adboio
approved these changes
Apr 2, 2026
Contributor
adboio
left a comment
adboio
left a comment
There was a problem hiding this comment.
THANK YOU i have tried to fix this so many times
Member
Author
Merge activity
|
charlesvien
changed the base branch from
04-02-add_release_notification_workflow
to
graphite-base/1467
charlesvien
force-pushed
the
04-02-only_show_cancelled_for_explicitly_cancelled_turns
branch
from
8bdc437 to
cacf5a8
Compare
charlesvien
deleted the
04-02-only_show_cancelled_for_explicitly_cancelled_turns
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tool calls pending permission incorrectly flash "(Cancelled)" because wasCancelled triggers on turnComplete, not just turnCancelled.
Closes #1267
Changes
How did you test this?
Manually