chore(code): disable terminal tabs for cloud run#1553
Merged
VojtechBartos merged 2 commits intomainfrom Apr 8, 2026
Merged
Conversation
skoob13
approved these changes
Apr 8, 2026
71bc964 to
cc19802
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Terminal doesn't work for cloud rins. The terminal tab and inline bash commands (
! command) are local-only features that shouldn't be available for cloud runs. Currently the terminal tab renders but shows nothing useful, the "+" button lets users add more empty terminal tabs, and typing! commandis silently dropped instead of being sent as a normal prompt.Changes
LeafNodeRendererfilters out terminal tabs before they reachuseTabInjection, so noTabContentRendereror shell process is ever created. The "+" add terminal button is also hidden. If the active tab was a terminal, it falls back to the first available tab.MessageEditoruses a newuseIsWorkspaceCloudRunhook to setcapabilities.bashModetofalse, which disables the!prefix visual indicator (blue ring). The submit function now also checksenableBashModebefore routing!text to the bash handler, so! textis submitted as a normal prompt instead of being silently dropped.useIsWorkspaceCloudRunhook — Thin wrapper arounduseWorkspacethat returnsworkspace?.mode === "cloud", used by bothLeafNodeRendererandMessageEditorto avoid prop drilling.How did you test this?
pnpm typecheck— all 9 packages passpnpm lint— no new warningspnpm --filter code test— 584/584 tests pass