fix(cloud-agent): propagate taskRunId through codex loadSession#1720
Open
tatoalo wants to merge 1 commit intofix/codex-prcontext-injectionfrom
Open
fix(cloud-agent): propagate taskRunId through codex loadSession#1720tatoalo wants to merge 1 commit intofix/codex-prcontext-injectionfrom
tatoalo wants to merge 1 commit intofix/codex-prcontext-injectionfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
tatoalo
force-pushed
the
fix/codex-loadsession-task-run
branch
from
463eb7f to
bfbea4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
newSessionandunstable_resumeSessionboth carry_meta.taskRunId/taskIdintosessionStateand emit_posthog/sdk_sessionon cloud runs.loadSessiondropped them on the floor. Re-attaching a desktop client to an existing cloud codex session therefore silencedTURN_COMPLETEandUSAGE_UPDATEon subsequent prompts (both gated onsessionState.taskRunId), and the adapter→session mapping was never published.Changes
In
CodexAcpAgent.loadSession, propagatetaskRunId/taskIdinto sessionState and fire_posthog/sdk_sessionwhentaskRunIdis present, matching the other session-creation paths.How did you test this?
taskRunIdis propagated andSDK_SESSIONfires when present; no extNotification is emitted whentaskRunIdis absent.@posthog/agentsuite green.