Skip to content

fix: anchor picker menus to ButtonGroup, remove overflow hidden#1734

Merged
adamleithp merged 1 commit intomainfrom
fix/cloud-repo-floating
Apr 20, 2026
Merged

fix: anchor picker menus to ButtonGroup, remove overflow hidden#1734
adamleithp merged 1 commit intomainfrom
fix/cloud-repo-floating

Conversation

@adamleithp
Copy link
Copy Markdown
Contributor

@adamleithp adamleithp commented Apr 20, 2026

Summary

  • Add anchor prop to FolderPicker, GitHubRepoPicker, and BranchSelector so their dropdown/combobox menus can anchor to a parent element
  • TaskInput passes a buttonGroupRef from the ButtonGroup wrapper to all three pickers, so menus align to the group without breaking its layout
  • Remove overflow: hidden from TaskInput container that was clipping focus rings and potentially popover content
2026-04-20 15 06 25 2026-04-20 15 08 17

Test plan

  • Open folder picker — dropdown anchors to the button group
  • Open GitHub repo picker (cloud mode) — combobox anchors to the button group
  • [ x Open branch selector — combobox anchors to the button group
  • [ x Verify focus rings on inputs aren't clipped
  • Verify BranchSelector still works standalone (e.g. in HeaderRow) without an anchor prop — falls back to its own internal ref

🤖 Generated with Claude Code

@adamleithp adamleithp merged commit b5f1848 into main Apr 20, 2026
15 checks passed
@adamleithp adamleithp deleted the fix/cloud-repo-floating branch April 20, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants