fix: skip session config call when local session is idle-killed

[jonathanlab]

No description provided.

[greptile-apps]

Prompt To Fix All With AI

This is a comment left during a code review.
Path: apps/code/src/renderer/features/sessions/service/service.test.ts
Line: 1500-1521

Comment:
**Incomplete assertions and missing `connecting` status coverage**

The `disconnected` test only checks that the backend call is skipped, but unlike the idle-killed test above it doesn't verify that the local session state and persisted config are still updated — which is the other half of the intended behaviour. Additionally, the `connecting` status is handled in the same conditional in `service.ts` but has no test at all.

Consider also parameterising all three cases (`idleKilled`, `disconnected`, `connecting`) into a single test, per the team's preference for parameterised tests. Example:

```ts
it.each([
  { desc: "idle-killed", overrides: { status: "error" as const, idleKilled: true } },
  { desc: "disconnected", overrides: { status: "disconnected" as const } },
  { desc: "connecting",   overrides: { status: "connecting" as const } },
])(
  "skips backend call when local session is $desc so reconnect restore handles it",
  async ({ overrides }) => {
    const service = getSessionService();
    mockSessionStoreSetters.getSessionByTaskId.mockReturnValue(
      createMockSession({
        ...overrides,
        configOptions: [
          { id: "mode", name: "Mode", type: "select", category: "mode", currentValue: "default", options: [] },
        ],
      }),
    );

    await service.setSessionConfigOption("task-123", "mode", "acceptEdits");

    expect(mockTrpcAgent.setConfigOption.mutate).not.toHaveBeenCalled();
    expect(mockSessionStoreSetters.updateSession).toHaveBeenCalledTimes(1);
    expect(mockSessionStoreSetters.updateSession).toHaveBeenCalledWith(
      "run-123",
      { configOptions: [expect.objectContaining({ id: "mode", currentValue: "acceptEdits" })] },
    );
    expect(mockSessionConfigStore.updatePersistedConfigOptionValue)
      .toHaveBeenCalledWith("run-123", "mode", "acceptEdits");
  },
);
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "fix: skip session config call when local..." | Re-trigger Greptile}

[greptile-apps]

Incomplete assertions and missing connecting status coverage

The disconnected test only checks that the backend call is skipped, but unlike the idle-killed test above it doesn't verify that the local session state and persisted config are still updated — which is the other half of the intended behaviour. Additionally, the connecting status is handled in the same conditional in service.ts but has no test at all.

Consider also parameterising all three cases (idleKilled, disconnected, connecting) into a single test, per the team's preference for parameterised tests. Example:

it.each([
  { desc: "idle-killed", overrides: { status: "error" as const, idleKilled: true } },
  { desc: "disconnected", overrides: { status: "disconnected" as const } },
  { desc: "connecting",   overrides: { status: "connecting" as const } },
])(
  "skips backend call when local session is $desc so reconnect restore handles it",
  async ({ overrides }) => {
    const service = getSessionService();
    mockSessionStoreSetters.getSessionByTaskId.mockReturnValue(
      createMockSession({
        ...overrides,
        configOptions: [
          { id: "mode", name: "Mode", type: "select", category: "mode", currentValue: "default", options: [] },
        ],
      }),
    );

    await service.setSessionConfigOption("task-123", "mode", "acceptEdits");

    expect(mockTrpcAgent.setConfigOption.mutate).not.toHaveBeenCalled();
    expect(mockSessionStoreSetters.updateSession).toHaveBeenCalledTimes(1);
    expect(mockSessionStoreSetters.updateSession).toHaveBeenCalledWith(
      "run-123",
      { configOptions: [expect.objectContaining({ id: "mode", currentValue: "acceptEdits" })] },
    );
    expect(mockSessionConfigStore.updatePersistedConfigOptionValue)
      .toHaveBeenCalledWith("run-123", "mode", "acceptEdits");
  },
);

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/code/src/renderer/features/sessions/service/service.test.ts
Line: 1500-1521

Comment:
**Incomplete assertions and missing `connecting` status coverage**

The `disconnected` test only checks that the backend call is skipped, but unlike the idle-killed test above it doesn't verify that the local session state and persisted config are still updated — which is the other half of the intended behaviour. Additionally, the `connecting` status is handled in the same conditional in `service.ts` but has no test at all.

Consider also parameterising all three cases (`idleKilled`, `disconnected`, `connecting`) into a single test, per the team's preference for parameterised tests. Example:

```ts
it.each([
  { desc: "idle-killed", overrides: { status: "error" as const, idleKilled: true } },
  { desc: "disconnected", overrides: { status: "disconnected" as const } },
  { desc: "connecting",   overrides: { status: "connecting" as const } },
])(
  "skips backend call when local session is $desc so reconnect restore handles it",
  async ({ overrides }) => {
    const service = getSessionService();
    mockSessionStoreSetters.getSessionByTaskId.mockReturnValue(
      createMockSession({
        ...overrides,
        configOptions: [
          { id: "mode", name: "Mode", type: "select", category: "mode", currentValue: "default", options: [] },
        ],
      }),
    );

    await service.setSessionConfigOption("task-123", "mode", "acceptEdits");

    expect(mockTrpcAgent.setConfigOption.mutate).not.toHaveBeenCalled();
    expect(mockSessionStoreSetters.updateSession).toHaveBeenCalledTimes(1);
    expect(mockSessionStoreSetters.updateSession).toHaveBeenCalledWith(
      "run-123",
      { configOptions: [expect.objectContaining({ id: "mode", currentValue: "acceptEdits" })] },
    );
    expect(mockSessionConfigStore.updatePersistedConfigOptionValue)
      .toHaveBeenCalledWith("run-123", "mode", "acceptEdits");
  },
);
```

How can I resolve this? If you propose a fix, please make it concise.