fix(onboarding): complete onboarding when last step continue is pressed#1843
Merged
joshsny merged 1 commit intoposthog-code/gate-inbox-behind-feature-flagfrom Apr 22, 2026
Conversation
When posthog-code-inbox flag is off, the signals step is filtered out, making install-cli the last step. The next() function is a no-op on the last step, so pressing Continue did nothing. Replace per-step onNext wiring with a unified handleNext that calls completeOnboarding when on the last active step, regardless of which step that is.
joshsny
merged commit 8860d13
into
posthog-code/gate-inbox-behind-feature-flag
10 checks passed
joshsny
added a commit
that referenced
this pull request
Apr 22, 2026
…ed (#1843) Co-authored-by: Cursor Agent <cursoragent@cursor.com>
|
Reviews (1): Last reviewed commit: "fix(onboarding): complete onboarding whe..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the
posthog-code-inboxfeature flag is off, pressing "Continue" (or "Skip for now") on the "Install required tools" step does nothing — the user is stuck and can't finish onboarding.Changes
The
"signals"step is filtered out ofactiveStepswhen the flag is off, making"install-cli"the last step. Butnext()is a no-op on the last step, andcompleteOnboarding()was only wired to the signals step'sonNexthandler.Replaced the per-step
onNextwiring with a unifiedhandleNextthat callscompleteOnboardingwhen on the last active step andnext()otherwise. This works regardless of which step ends up being last (whether signals is filtered out or not).How did you test this?
Slack Thread