Skip to content

feat(code): migrate header row items to Quill#1850

Merged
charlesvien merged 3 commits intomainfrom
ui/rework-diff-git-buttons
Apr 23, 2026
Merged

feat(code): migrate header row items to Quill#1850
charlesvien merged 3 commits intomainfrom
ui/rework-diff-git-buttons

Conversation

@adamleithp
Copy link
Copy Markdown
Contributor

@adamleithp adamleithp commented Apr 23, 2026

Summary

  • GitInteractionMenu: Replace Radix UI Button/DropdownMenu with Quill Button/ButtonGroup/DropdownMenu. Use variant="primary" for active split button. Hide dropdown when all actions disabled.
  • ExternalAppsOpener: Replace raw <button> and Radix DropdownMenu with Quill ButtonGroup/Button/DropdownMenu. UX fix: call setLastUsedApp when selecting from dropdown so the main button icon updates to the user's last choice. Use onClick (not onSelect) for Base UI DropdownMenuItem. Wrap shortcuts in Kbd.
  • DiffStatsBadge: Replace raw <button> with Quill Button (variant="outline", size="sm").
  • HeaderRow: Remove left border separator, adjust padding for tighter layout.
  • TaskDetail: Remove redundant Flex wrapper around ExternalAppsOpener.
2026-04-23 01 23 48

Test plan

  • Git interaction split button renders with primary (orange) styling
  • Dropdown chevron hidden when all git actions disabled
  • Git dropdown items open correct modals (commit, push, create PR, etc.)
  • External apps: main button opens default app
  • External apps: selecting from dropdown opens app AND updates main button icon
  • External apps: ⌘O shortcut still works
  • DiffStatsBadge toggles review panel
  • Header row spacing looks correct, no left border

🤖 Generated with Claude Code

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 23, 2026

Prompt To Fix All With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/git-interaction/components/GitInteractionMenu.tsx
Line: 129-132

Comment:
**Use `onClick` instead of `onSelect`**

Same fix applied to `ExternalAppsOpener` — Quill's `DropdownMenuItem` is a Base UI component that uses `onClick`, not `onSelect`. The current `onSelect` prop is silently ignored, so clicking any item in the git dropdown does nothing.

```suggestion
              <DropdownMenuItem
                key={action.id}
                onClick={() => onSelect(action.id)}
              >
```

How can I resolve this? If you propose a fix, please make it concise.

Reviews (1): Last reviewed commit: "fix(code): polish header row items and f..." | Re-trigger Greptile

@adamleithp adamleithp requested a review from a team April 23, 2026 00:26
adamleithp and others added 3 commits April 22, 2026 18:49
Replace Radix UI buttons with Quill Button/ButtonGroup/DropdownMenu
components for the git interaction split button (Commit, Push, etc).
Use variant="primary" for the active state. Hide dropdown when all
actions are disabled. Also migrate DiffStatsBadge to Quill Button
and tighten header row gap.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace raw <button> elements and Radix DropdownMenu with Quill
ButtonGroup/Button/DropdownMenu components. Call setLastUsedApp when
selecting from dropdown so the main button icon updates to reflect
the user's last choice.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- ExternalAppsOpener: use onClick (not onSelect) for Quill
  DropdownMenuItem, bump icon size, wrap shortcuts in Kbd,
  use icon-sm button size
- DiffStatsBadge: use variant="outline" size="sm", reduce className
- HeaderRow: remove left border, adjust padding
- TaskDetail: remove redundant Flex wrapper around ExternalAppsOpener

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@charlesvien charlesvien force-pushed the ui/rework-diff-git-buttons branch from 6a3da24 to 0ef7a68 Compare April 23, 2026 01:49
Copy link
Copy Markdown
Member

@charlesvien charlesvien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Member

@charlesvien charlesvien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charlesvien charlesvien enabled auto-merge (squash) April 23, 2026 01:53
@charlesvien charlesvien merged commit f7a03e0 into main Apr 23, 2026
16 checks passed
@charlesvien charlesvien deleted the ui/rework-diff-git-buttons branch April 23, 2026 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants