feat(code): migrate header row items to Quill#1850
Merged
charlesvien merged 3 commits intomainfrom Apr 23, 2026
Merged
Conversation
Prompt To Fix All With AIThis is a comment left during a code review.
Path: apps/code/src/renderer/features/git-interaction/components/GitInteractionMenu.tsx
Line: 129-132
Comment:
**Use `onClick` instead of `onSelect`**
Same fix applied to `ExternalAppsOpener` — Quill's `DropdownMenuItem` is a Base UI component that uses `onClick`, not `onSelect`. The current `onSelect` prop is silently ignored, so clicking any item in the git dropdown does nothing.
```suggestion
<DropdownMenuItem
key={action.id}
onClick={() => onSelect(action.id)}
>
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "fix(code): polish header row items and f..." | Re-trigger Greptile |
Replace Radix UI buttons with Quill Button/ButtonGroup/DropdownMenu components for the git interaction split button (Commit, Push, etc). Use variant="primary" for the active state. Hide dropdown when all actions are disabled. Also migrate DiffStatsBadge to Quill Button and tighten header row gap. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace raw <button> elements and Radix DropdownMenu with Quill ButtonGroup/Button/DropdownMenu components. Call setLastUsedApp when selecting from dropdown so the main button icon updates to reflect the user's last choice. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- ExternalAppsOpener: use onClick (not onSelect) for Quill DropdownMenuItem, bump icon size, wrap shortcuts in Kbd, use icon-sm button size - DiffStatsBadge: use variant="outline" size="sm", reduce className - HeaderRow: remove left border, adjust padding - TaskDetail: remove redundant Flex wrapper around ExternalAppsOpener Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6a3da24 to
0ef7a68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Button/DropdownMenuwith QuillButton/ButtonGroup/DropdownMenu. Usevariant="primary"for active split button. Hide dropdown when all actions disabled.<button>and Radix DropdownMenu with QuillButtonGroup/Button/DropdownMenu. UX fix: callsetLastUsedAppwhen selecting from dropdown so the main button icon updates to the user's last choice. UseonClick(notonSelect) for Base UI DropdownMenuItem. Wrap shortcuts inKbd.<button>with QuillButton(variant="outline",size="sm").Flexwrapper aroundExternalAppsOpener.Test plan
🤖 Generated with Claude Code