feat: add context menu support for editable fields#1870
Merged
Conversation
Generated-By: PostHog Code Task-Id: b318a92e-0eeb-4cd9-8602-e64a1ee35c09
oliverb123
approved these changes
Apr 23, 2026
Contributor
Prompt To Fix All With AIThis is a comment left during a code review.
Path: apps/code/src/renderer/features/message-editor/components/PromptInput.tsx
Line: 277-279
Comment:
**stopPropagation applied to entire InputGroup, not just the editor**
`handleContextMenu` unconditionally stops propagation on the `InputGroup` wrapper, which also encloses the send button and the `AttachmentsBar`. Right-clicking those sub-elements will suppress the Radix context menu without triggering the Electron native menu either (since `params.isEditable` will be `false` for a button/non-editable area), leaving the user with no context menu at all. This matches the pattern used by `SessionView`'s handler — which only stops propagation when the target is actually an editable element — so aligning the two would be more consistent.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "feat: add context menu support for edita..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
277
to
279
| onClick={handleContainerClick} | ||
| onContextMenu={handleContextMenu} | ||
| className={`h-auto bg-card ${isBashMode ? "ring-1 ring-blue-9" : ""}`} |
Contributor
There was a problem hiding this comment.
handleContextMenu unconditionally stops propagation on the InputGroup wrapper, which also encloses the send button and the AttachmentsBar. Right-clicking those sub-elements will suppress the Radix context menu without triggering the Electron native menu either (since params.isEditable will be false for a button/non-editable area), leaving the user with no context menu at all. This matches the pattern used by SessionView's handler — which only stops propagation when the target is actually an editable element — so aligning the two would be more consistent.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/message-editor/components/PromptInput.tsx
Line: 277-279
Comment:
**stopPropagation applied to entire InputGroup, not just the editor**
`handleContextMenu` unconditionally stops propagation on the `InputGroup` wrapper, which also encloses the send button and the `AttachmentsBar`. Right-clicking those sub-elements will suppress the Radix context menu without triggering the Electron native menu either (since `params.isEditable` will be `false` for a button/non-editable area), leaving the user with no context menu at all. This matches the pattern used by `SessionView`'s handler — which only stops propagation when the target is actually an editable element — so aligning the two would be more consistent.
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now you can right click > paste
Created with PostHog Code