Skip to content

feat(code): fix padding on command center new task UI#1927

Merged
jonathanlab merged 1 commit intomainfrom
04-28-feat_code_fix_padding_on_command_center_new_task_ui
Apr 29, 2026
Merged

feat(code): fix padding on command center new task UI#1927
jonathanlab merged 1 commit intomainfrom
04-28-feat_code_fix_padding_on_command_center_new_task_ui

Conversation

@adboio
Copy link
Copy Markdown
Contributor

@adboio adboio commented Apr 28, 2026

Problem

the new task UI in the command center, on small screen sizes, has no padding

Changes

  • adds padding
  • [lazy-fix, but good regardless imo] drops the "Effort"/"Reasoning" label from dropdown

Screenshot 2026-04-28 at 12.10.50 PM.png

How did you test this?

manually

@adboio adboio requested a review from a team April 28, 2026 19:11
@adboio adboio marked this pull request as ready for review April 28, 2026 19:11
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 28, 2026

Comments Outside Diff (1)

  1. apps/code/src/renderer/features/sessions/components/ReasoningLevelSelector.tsx, line 65 (link)

    P2 prefix not reused in MenuLabel

    The prefix variable was introduced to avoid repeating adapter === "codex" ? "Reasoning" : "Effort", but the same expression still appears inline here. Reusing prefix would satisfy OnceAndOnlyOnce.

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: apps/code/src/renderer/features/sessions/components/ReasoningLevelSelector.tsx
    Line: 65
    
    Comment:
    **`prefix` not reused in `MenuLabel`**
    
    The `prefix` variable was introduced to avoid repeating `adapter === "codex" ? "Reasoning" : "Effort"`, but the same expression still appears inline here. Reusing `prefix` would satisfy OnceAndOnlyOnce.
    
    
    
    How can I resolve this? If you propose a fix, please make it concise.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix All With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/sessions/components/ReasoningLevelSelector.tsx
Line: 65

Comment:
**`prefix` not reused in `MenuLabel`**

The `prefix` variable was introduced to avoid repeating `adapter === "codex" ? "Reasoning" : "Effort"`, but the same expression still appears inline here. Reusing `prefix` would satisfy OnceAndOnlyOnce.

```suggestion
        <MenuLabel>{prefix}</MenuLabel>
```

How can I resolve this? If you propose a fix, please make it concise.

Reviews (1): Last reviewed commit: "feat(code): fix padding on command cente..." | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

jonathanlab commented Apr 29, 2026

Merge activity

  • Apr 29, 10:20 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 29, 10:46 AM UTC: Graphite rebased this pull request as part of a merge.
  • Apr 29, 10:55 AM UTC: @jonathanlab merged this pull request with Graphite.

@jonathanlab jonathanlab changed the base branch from 04-28-feat_code_fix_command_approval_option_vertical_alignment to graphite-base/1927 April 29, 2026 10:30
@jonathanlab jonathanlab changed the base branch from graphite-base/1927 to main April 29, 2026 10:44
@jonathanlab jonathanlab force-pushed the 04-28-feat_code_fix_padding_on_command_center_new_task_ui branch from 30a8962 to 14f1e70 Compare April 29, 2026 10:45
@jonathanlab jonathanlab merged commit 8fdf296 into main Apr 29, 2026
16 checks passed
@jonathanlab jonathanlab deleted the 04-28-feat_code_fix_padding_on_command_center_new_task_ui branch April 29, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants