Skip to content

chore(code): remove diff agent actions flag #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adboio wants to merge 1 commit into
base: main
Choose a base branch
from
+44 −65
Open

chore(code): remove diff agent actions flag #1962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 44 additions & 65 deletions apps/code/src/renderer/features/code-review/components/PrCommentThread.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { MarkdownRenderer } from "@features/editor/components/MarkdownRenderer";
import { sendPromptToAgent } from "@features/sessions/utils/sendPromptToAgent";
import { useFeatureFlag } from "@hooks/useFeatureFlag";
import type { PrReviewComment } from "@main/services/git/schemas";
import {
CaretDown,
Expand All @@ -11,15 +10,8 @@ import {
WarningCircle,
X,
} from "@phosphor-icons/react";
import {
Avatar,
Badge,
Box,
Button,
Flex,
IconButton,
Text,
} from "@radix-ui/themes";
import { Button } from "@posthog/quill";
import { Avatar, Badge, Box, Flex, Text } from "@radix-ui/themes";
import { isSendMessageSubmitKey } from "@utils/sendMessageKey";
import { formatRelativeTimeShort } from "@utils/time";
import { useCallback, useEffect, useRef, useState } from "react";
Expand Down Expand Up @@ -71,8 +63,6 @@ function ThreadActionBar({
onKeyDown,
textareaRefCallback,
}: ThreadActionBarProps) {
const agentActionsEnabled = useFeatureFlag("posthog-code-pr-agent-actions");

if (showReplyBox) {
return (
<div className="mt-1.5 border-[var(--gray-4)] border-t pt-1.5">
Expand All @@ -82,19 +72,19 @@ function ThreadActionBar({
onKeyDown={onKeyDown}
className="min-h-[48px] w-full resize-none rounded border border-[var(--gray-6)] bg-[var(--color-background)] p-1.5 text-[13px] text-[var(--gray-12)] leading-normal outline-none"
/>
<Flex align="center" gap="3" className="mt-1.5">
<Button size="1" onClick={onSubmitReply} disabled={!!pendingReply}>
<ChatCircle size={12} />
<Flex align="center" gap="2" className="mt-1.5">
<Button
variant="primary"
size="sm"
onClick={onSubmitReply}
disabled={!!pendingReply}
>
<ChatCircle />
{pendingReply ? "Sending..." : "Reply"}
</Button>
<IconButton
size="1"
variant="ghost"
color="gray"
onClick={onHideReplyBox}
>
<X size={12} />
</IconButton>
<Button size="icon-sm" onClick={onHideReplyBox}>
<X />
</Button>
</Flex>
</div>
);
Expand All @@ -107,46 +97,37 @@ function ThreadActionBar({
className="mt-1 border-[var(--gray-4)] border-t pt-1.5"
>
{prUrl && (
<Button size="1" variant="ghost" color="gray" onClick={onShowReplyBox}>
<ChatCircle size={12} />
<Button size="sm" onClick={onShowReplyBox}>
<ChatCircle />
Reply
</Button>
)}
{/* TODO: remove this flag when https://github.com/posthog/code/issues/1533 is fixed
currently set to 0% rollout. didn't discover the cloud bug until i had already built this
xoxo, adboio */}
{agentActionsEnabled && (
<>
<Button
size="1"
variant="ghost"
color="gray"
onClick={() =>
sendPromptToAgent(
taskId,
buildFixPrCommentPrompt(filePath, endLine, side, comments),
)
}
>
<Robot size={12} />
Fix with agent
</Button>
<Button
size="1"
variant="ghost"
color="gray"
onClick={() =>
sendPromptToAgent(
taskId,
buildAskAboutPrCommentPrompt(filePath, endLine, side, comments),
)
}
>
<Robot size={12} />
Ask agent
</Button>
</>
)}

<Button
size="sm"
onClick={() =>
sendPromptToAgent(
taskId,
buildFixPrCommentPrompt(filePath, endLine, side, comments),
)
}
>
<Robot />
Fix with agent
</Button>

<Button
size="sm"
onClick={() =>
sendPromptToAgent(
taskId,
buildAskAboutPrCommentPrompt(filePath, endLine, side, comments),
)
}
>
<Robot />
Ask agent
</Button>
Comment on lines +106 to +130
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Agent actions exposed before cloud bug is confirmed fixed

The removed comment explicitly linked this flag to an unresolved cloud bug (#1533): "currently set to 0% rollout. didn't discover the cloud bug until i had already built this." The PR description doesn't mention issue #1533 being resolved. If it's still open, "Fix with agent" and "Ask agent" will now fire sendPromptToAgent for all users in production rather than 0%.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: apps/code/src/renderer/features/code-review/components/PrCommentThread.tsx
Line: 106-130

Comment:
**Agent actions exposed before cloud bug is confirmed fixed**

The removed comment explicitly linked this flag to an unresolved cloud bug (https://github.com/posthog/code/issues/1533): *"currently set to 0% rollout. didn't discover the cloud bug until i had already built this."* The PR description doesn't mention issue #1533 being resolved. If it's still open, "Fix with agent" and "Ask agent" will now fire `sendPromptToAgent` for all users in production rather than 0%.

How can I resolve this? If you propose a fix, please make it concise.

</Flex>
);
}
Expand Down Expand Up @@ -232,20 +213,18 @@ function CommentBody({
</Box>
{isOverflowing && (
<Button
size="1"
variant="ghost"
color="gray"
size="sm"
onClick={() => setIsExpanded((prev) => !prev)}
className="mt-1"
>
{isExpanded ? (
<>
<CaretUp size={12} />
<CaretUp />
Show less
</>
) : (
<>
<CaretDown size={12} />
<CaretDown />
Show more
</>
)}
Expand Down
Loading