Skip to content

fix: default cloud tasks to personal github auth#2081

Merged
tatoalo merged 2 commits intomainfrom
investigation_imane
May 7, 2026
Merged

fix: default cloud tasks to personal github auth#2081
tatoalo merged 2 commits intomainfrom
investigation_imane

Conversation

@tatoalo
Copy link
Copy Markdown
Contributor

@tatoalo tatoalo commented May 7, 2026

Problem

Manual cloud task creation could default to bot-authored GitHub writes when the client did not resolve a selected repository to a personal GitHub integration. That made cloud runs depend on the project-level GitHub installation even when the user had linked a personal installation for the repository.

@tatoalo tatoalo closed this May 7, 2026
@tatoalo tatoalo self-assigned this May 7, 2026
@tatoalo tatoalo reopened this May 7, 2026
@tatoalo tatoalo requested a review from a team May 7, 2026 13:41
@tatoalo tatoalo marked this pull request as ready for review May 7, 2026 13:42
cloudPrAuthorshipMode:
options.signalReportId && options.workspaceMode === "cloud"
? "user"
? "bot"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why from user to bot?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore me, seeing it's the signal stuff

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is signal yep but let's not change it here, reverting anyway

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 7, 2026

Reviews (1): Last reviewed commit: "Merge branch 'main' into investigation_i..." | Re-trigger Greptile

@tatoalo tatoalo force-pushed the investigation_imane branch from ad4aac6 to fb53535 Compare May 7, 2026 13:55
@tatoalo tatoalo force-pushed the investigation_imane branch from fb53535 to 4249a96 Compare May 7, 2026 13:56
@tatoalo tatoalo enabled auto-merge (squash) May 7, 2026 13:56
@tatoalo tatoalo merged commit 6775190 into main May 7, 2026
15 checks passed
@tatoalo tatoalo deleted the investigation_imane branch May 7, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants