feat(auth): Make region picker prominent on sign-in#2090
Merged
Conversation
Surface a side-by-side US Cloud / EU Cloud chooser above the sign-in button so non-technical users can no longer miss the region choice. Previously the region was buried behind a small "change" link, which caused EU customers to silently log into US Cloud and land on an empty project. The selected region is now also echoed on the sign-in button itself for an extra confirmation cue. Generated-By: PostHog Code Task-Id: d739b1d2-b053-45ec-967b-5521802d275b
5 tasks
Twixes
changed the title
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/code/src/renderer/features/auth/components/OAuthControls.tsx:56
The template literal here adds no value — there is no interpolation, so a plain string is simpler and more consistent with the `"Cancel"` branch on the same line. This violates the "no superfluous parts" simplicity rule.
```suggestion
{isPending ? "Cancel" : "Sign in / sign up with PostHog"}
```
Reviews (1): Last reviewed commit: "Clean up" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Contributor
|
Reviews (2): Last reviewed commit: "Update apps/code/src/renderer/features/a..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The EU vs. US Cloud region choice was buried behind a tiny "change" link rendered below the sign-in button. EU customers missed it incredibly easily, signed into US Cloud by accident, and ended up looking at an error.
Changes
This PR replaces the link with a side-by-side "US Cloud / EU Cloud" picker rendered above the sign-in button.
The "local dev" region remains accessible too, only in dev.
Created with PostHog Code